-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cost saving functionality #1218
Disable cost saving functionality #1218
Conversation
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#1217 - this change adds aconfiguration glag that force disabling the cost savings - even when a cluster or platform is part of teh argument, the Q tool output won't include any data related to costs. - this is temp solution to disable the cost-savings. Later, there will be other issues to cleanup the dead-code
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amahussein. LGTME. I have few questions:
- What are the plans for the argument
--filter_apps savings
? It would currently throw an exception for the following CMD:
spark_rapids qualification --platform databricks-aws --eventlogs $EVENTLOG_PATH --tools_jar $SPARK_RAPIDS_TOOLS_JAR --filter_apps savings --cluster ~/Work/cluster/databricks-aws/databricks-aws-cpu.json
2 Do we plan to remove 'SAVINGS' word from the console output when we clean up the csv files columns?
- Summarized savings and speedups CSV report: /Users/psarthi/Work/tools-run/qual_20240723194339_11E13C20/qualification_summary.csv
- Full savings and speedups CSV report: /Users/psarthi/Work/tools-run/qual_20240723194339_11E13C20/qualification_summary_full.csv
Yes, we need to remove arguments related to the cost-savings, and do all the other logistics. The purpose of this PR is an immediate block to cancel Cost-savings.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amahussein. RIP cost savings.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #1217
The full list of tasks is tracked in #1221