Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Generate and use instance description file for Databricks-Azure platform #1232

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[FEA] Generate and use instance description file for Databricks-Azure platform #1232

merged 1 commit into from
Jul 29, 2024

Conversation

cindyyuanjiang
Copy link
Collaborator

Contributes to #1191

Changes

  • Added instance description file for DB-Azure under resources
  • Updated DB-Azure user qual tool to look up instance info in the above file

Testing

  • Cluster properties file
spark_rapids qualification --eventlogs <my-event-logs> --platform databricks-azure --cluster <my-cluster-file>
  • Cluster name
spark_rapids qualification --eventlogs <my-event-logs> --platform databricks-azure --cluster <my-cluster-name>

@cindyyuanjiang
fix instance file tyle error
ebf1d52 
Signed-off-by: cindyyuanjiang <[email protected]>
@cindyyuanjiang cindyyuanjiang added feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python) usability track issues related to the Tools's user experience labels Jul 25, 2024
@cindyyuanjiang cindyyuanjiang self-assigned this Jul 25, 2024
@cindyyuanjiang cindyyuanjiang mentioned this pull request Jul 26, 2024
Closed
parthosa
parthosa approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang. Tested the cases on a new machine:

  • No cluster provided
  • Cluster json provided
  • Cluster name provided.

amahussein
amahussein approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang !
LGTME

@cindyyuanjiang cindyyuanjiang merged commit e4cca3d into NVIDIA:dev Jul 29, 2024
15 checks passed
@cindyyuanjiang cindyyuanjiang deleted the spark-rapids-tools-1191-azure branch July 29, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amahussein amahussein amahussein approved these changes

@parthosa parthosa parthosa approved these changes

@nartal1 nartal1 Awaiting requested review from nartal1

Assignees

@cindyyuanjiang cindyyuanjiang

Labels
feature request New feature or request usability track issues related to the Tools's user experience user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cindyyuanjiang @parthosa @amahussein