-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve console output from python tool for failed/gpu/photon event logs #1235
Conversation
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTME!
Thanks @parthosa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa! LGTM.
did this change the output of the top candidate table and location of where the * and ** definition is? like:
is now above the table? |
Fixes #1126.
#1187 added feature in scala tools to include the status report of all apps even those which had failed or skipped due to photon event logs. This PR improves python tools to alway display num of processed apps (even if passed GPU event logs or Streaming logs or any other failure)
Output
Case 1 : Event logs with no successfull apps: photon/gpu/csp event log with authentication issue
Previously
After this change
Case 2: Event logs with no top candidates
Console Output
Case 3: Event logs path with some top candidate apps, some gpu apps/photon apps
Console Output
Changes
qualification.py::QualificationSummary
:all_apps
anddf_results
DFsqualification.py::Qualification
:_read_qualification_output_file()
that reads files generated from the scala output folder