-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip generating timeline for stages that do not have completion time #1290
Conversation
Signed-off-by: Niranjan Artal <[email protected]>
so the downside to this is the person looking at the graph doesn't see that there was a stage there. Is there an easy way on the graph to say it goes til the end of the chart? Do we have any end time, like job end? |
Unfortunately, that's the case with the eventlogs which don't have stageEnd time or jobEnd time. If the stage is not completed, we won't have the jobEnd time either. So in the graph, we are skipping those in the JOBS section. Another reason we cannot plot it is the duration will be set as "zero" for these cases. And duration is required for plotting in the graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1!
Right but arguably similar to the Spark UI, these things should just be shown as RUNNING.. so in a graph they would show the start time and no stop time. Otherwise someone looking at the graph could totally miss those. If the jobs section do this now (please confirm)? I'm ok with this fix short term but we may want to file a followup to investigate if there is a way to show them from start to the end of whatever the graph shows. |
Thanks @tgravescs ! We are skipping those for jobs and stages. Since we see those in history server, we should probably update our code as well instead of skipping those. Have filed a follow up issue to investigate that - #1295 |
This fixes a small bug when the tools is run with --generate-timeline argument on an incomplete eventlog.
The issue is that the completionTime of a stage can be None for inprogess eventlogs and we see error message as below. The fix is to generate timeline only for completed stages.
In this function, we already do similar checks for
jobIdToInfo
andsqlIdToInfo
.Error without this fix:
With this PR: