-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualification tool - Add option to filter by minimum event log size #1291
Conversation
Signed-off-by: Thomas Graves <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tgravescs. nit: Short flag -m
might conflict with max
filter arg.
actually it looks like it changed -m to be min instead of max, let me look at that |
fixed the short -m option to go back to --max-event-log-size. I also changed this min to be >= as I think that makes more sense to user.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tgravescs.
Similar to #1275, bad here filter out files smaller then a certain size. This allows users to do ranges.
Manually tested. Tested with this option alone and then also with max size and the filter criteria to make sure all work together.