Allow spark dependency to be configured dynamically #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein <[email protected]> Fixes NVIDIA#1316 Allow user-tools to pick the SPARK dependencies based on a runtime env_var. The value format follows the same format of `buildver` in the scala pom file. Currently 333 and 350 (default) are supported. If user specifies an invalid value, there will be a warning message, then the process fails running the java cmd. **Changes** - Add dependency key to the platform config-file - A platform can define its own default dependency versions using `activeBuildVer` key - Add a default `RUNTIME_BUILDVER` in the `__init__.py` to allow upgrades of spark release during official releases - Read an env_var `RAPIDS_USER_TOOLS_RUNTIME_BUILDVER` to pick the correct dependency. - Currently, only `333` and `350` are supported. Default is `350`
amahussein
added
feature request
parthosa
reviewed
Sep 3, 2024
user_tools/src/spark_rapids_pytools/resources/onprem-configs.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein <[email protected]>
Signed-off-by: Ahmed Hussein <[email protected]>
parthosa
reviewed
Sep 3, 2024
tgravescs
reviewed
Sep 4, 2024
tgravescs
reviewed
Sep 4, 2024
user_tools/src/spark_rapids_pytools/resources/databricks_aws-configs.json
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein <[email protected]>
parthosa
previously approved these changes
Sep 4, 2024
tgravescs
reviewed
Sep 5, 2024
Signed-off-by: Ahmed Hussein <[email protected]>
parthosa
approved these changes
Sep 6, 2024
tgravescs
approved these changes
Sep 6, 2024
amahussein
added a commit
to amahussein/spark-rapids-tools
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Followup on NVIDIA#1326 to set the default spark version to 3.4.2 for onPrem to avoid the bug described in NVIDIA#1316 without need to do something on customer side.
amahussein
added a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Followup on #1326 to set the default spark version to 3.4.2 for onPrem to avoid the bug described in #1316 without need to do something on customer side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein [email protected]
Fixes #1316
Allow user-tools to pick the SPARK dependencies based on a runtime env_var. The value format follows the same format of
buildverin the scala pom file.Currently 333 and 350 (default) are supported.
If user specifies an invalid value, there will be a warning message, then the process fails running the java cmd.
Changes
activeBuildVerkeyRUNTIME_BUILDVERin the__init__.pyto allow upgrades of spark release during official releasesRAPIDS_USER_TOOLS_SPARK_DEP_VERSIONto pick the correct dependency.333and350are supported. Default is350Docs changes
RAPIDS_USER_TOOLS_SPARK_DEP_VERSIONPossible followups