-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Catch Profiler error when app info is empty #994
Conversation
Signed-off-by: cindyyuanjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang !
QQ: since we are trying to reduce the gap betwen Q/P tools, How feasible do you think it is to handle PRofiling tool the same way we do in Q tool? For example, generate a file like rapids_4_spark_qualification_output_status.csv
reporting the status of processing of each eventlog ?
If you find it an easy change, then it will be nice to handle it in this PR.
@parthosa do you recall if we have an exiting issue to generate status report for Profiling tool?
Thanks @amahussein! |
Filed issue to track adding status report for profiling tool: #998, will add feature in a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: @cindyyuanjiang Did you test with multiple eventlog that throwing RuntimeExcpetion won't cause the entire Profiler app to Exit?
We want to make sure that runtimeExcprion won't crash the execution and cause the processing of other apps to be terminated.
Thanks @amahussein! I tested with multiple event logs and confirm that change in this PR would not crash the Profiler. The Profiler would continue to run until all apps are processed. The eventlog which throws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang
Fixes #947
The Profiler could fail when: it successfully creates an
ApplicationInfo
increateApp
, when processing this app inprocessApps
, the Profiler found that it is unable to collect information from this app ingetAppInfo
. This leads to an emptyappInfo
inspark-rapids-tools/core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/Profiler.scala
Line 338 in f163fcc
spark-rapids-tools/core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/Profiler.scala
Line 410 in f163fcc
This PR catches the error early and prints a more helpful message.