Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Failing ToPrettyStringSuite Test for 3.5.0 #10059

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fixed Failing ToPrettyStringSuite Test for 3.5.0 #10059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a699d1
Fixed failing ToPrettyStringSuite test
razajafri Dec 15, 2023
9bd26f9
Signing off
razajafri Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions tests/src/test/spark341db/scala/com/nvidia/spark/rapids/ToPrettyStringSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import ai.rapids.cudf.ColumnVector
import com.nvidia.spark.rapids.Arm._
import com.nvidia.spark.rapids.GpuColumnVector.GpuColumnarBatchBuilder
import com.nvidia.spark.rapids.shims.GpuToPrettyString
import org.scalatest.exceptions.TestFailedException

import org.apache.spark.sql.catalyst.expressions.{BoundReference, NamedExpression, ToPrettyString}
import org.apache.spark.sql.types.{ArrayType, DataType, DataTypes, DecimalType, MapType, StructField, StructType}
Expand Down Expand Up @@ -78,15 +77,11 @@ class ToPrettyStringSuite extends GpuUnitTests {
}

test("test show() on floats") {
// This test is expected to fail until https://github.com/NVIDIA/spark-rapids/issues/4204
// is resolved
assertThrows[TestFailedException](testDataType(DataTypes.FloatType))
testDataType(DataTypes.FloatType)
}

test("test show() on doubles") {
// This test is expected to fail until https://github.com/NVIDIA/spark-rapids/issues/4204
// is resolved
assertThrows[TestFailedException](testDataType(DataTypes.DoubleType))
testDataType(DataTypes.DoubleType)
}

test("test show() on strings") {
Expand Down