Refactor GpuJsonToStruct to reduce code duplication and manage resources more efficiently #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces more efficiently
andygrove
commented
Dec 20, 2023
| @@ -37,6 +37,8 @@ case class GpuJsonToStructs( | |||
| extends GpuUnaryExpression with TimeZoneAwareExpression with ExpectsInputTypes | |||
| with NullIntolerant { | |||
|
|
|||
| lazy val emptyRowStr = constructEmptyRow(schema) | |||
There was a problem hiding this comment.
I moved this to the top of the class rather than declare it between methods
Signed-off-by: Andy Grove <[email protected]>
revans2
approved these changes
Dec 26, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10001
This PR is a small refactor that does not change functionality but reduces some code duplication and also releases some resources sooner. It is unlikely that this will make much of a difference, but it is technically more efficient.