fix test_hash_agg_with_nan_keys floating point sum failure #10148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Brennan <[email protected]>
|
build |
revans2
previously approved these changes
Jan 3, 2024
|
Updated copyrights... |
|
build |
revans2
approved these changes
Jan 3, 2024
mythrocks
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10026.
This fixes the failures for
test_hash_agg_with_nan_keysby changing the test to sum a column of Integers instead of Floats. The summing of floating point values is not the aim of this unit test. See this comment.This also changes
test_count_distinct_with_nan_floatsto use_grpkey_floats_with_nulls_and_nansinstead of_grpkey_doubles_with_nan_zero_grouping_keys, because the latter was changed so that the b column is Integers instead of Floats, and this test needs a column of Floats (with nans).My proposal is to use this pr to fix #10026, and continue investigating the floating point sum differences in #9822.