Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spark 334 Build #10162

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Fix Spark 334 Build #10162

merged 4 commits into from
Jan 8, 2024

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Jan 6, 2024

Fixes #10163

As part of #10054 GpuAscii.scala was added but it wasn't added to Spark 3.3.4. This was not caught by the nightly builds because it was missed as part of the original PR that added the plugin support for 334

This PR adds the GpuAscii.scala to 334 and also adds 334 to noSnapshot in pom.xml so 334 can be added to the nightly builds.

Testing

Ran the test_ascii integration test and it passed

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending green PR checks once the private artifact is published.

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Jan 7, 2024

build

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Jan 8, 2024

@razajafri

rapids-private-spark334.jar is available

Merged this change to unblock the nightly builds/tests

If any unsolved issue, please help follow it up, thanks!

@NvTimLiu NvTimLiu merged commit d4ec3e9 into NVIDIA:branch-24.02 Jan 8, 2024
40 checks passed
@razajafri razajafri deleted the fix-334-build branch January 8, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spark 3.3.4 Shim Build Failure
4 participants