Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy mode for yyyymmdd format [databricks] #11493

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Sep 24, 2024

closes #11505

Required by customer.

Similar to this PR which supports yyyyMMdd, this PR supports yyyymmdd

Note: MM is month while mm is minute

Note: GPU and CPU are not 100% consistent for yyyymmdd format, GPU only supports 8 digit strings.

Signed-off-by: Chong Gao [email protected]

@res-life res-life changed the base branch from branch-24.10 to branch-24.12 September 24, 2024 08:15
@res-life res-life changed the title Support legacy mode for yyyymmdd format Support legacy mode for yyyymmdd format [databricks] Sep 24, 2024
@res-life
Copy link
Collaborator Author

build

@firestarman
Copy link
Collaborator

firestarman commented Sep 24, 2024

is yyyymmdd an legal format string for date ?

yyyy represents the year, but mm for minutes ? Isn't weird that a date is in the format of {year}{minute}{day} ?

@res-life
Copy link
Collaborator Author

is yyyymmdd an legal format string for date ?

yyyy represents the year, but mm for minutes ? Isn't weird that a date is in the format of {year}{minute}{day} ?

In general, it's weird. But it's a valid format.
{year}{minute}{day} does specify year, minute and day; the missed parts like {month}{hour}{second} have default values. e.g.: month default value is 1.

@firestarman
Copy link
Collaborator

firestarman commented Sep 24, 2024

is yyyymmdd an legal format string for date ?
yyyy represents the year, but mm for minutes ? Isn't weird that a date is in the format of {year}{minute}{day} ?

In general, it's weird. But it's a valid format. {year}{minute}{day} does specify year, minute and day; the missed parts like {month}{hour}{second} have default values. e.g.: month default value is 1.

The code looks good, but I am not 100% sure on its functionality, and would like to wait for the premerge result and verification from customer runs before approving it.

@res-life res-life changed the title Support legacy mode for yyyymmdd format [databricks] Support legacy mode for yyyymmdd format Sep 24, 2024
@res-life
Copy link
Collaborator Author

build

@res-life res-life changed the title Support legacy mode for yyyymmdd format Support legacy mode for yyyymmdd format [databricks] Sep 25, 2024
@res-life
Copy link
Collaborator Author

build

@pxLi
Copy link
Collaborator

pxLi commented Sep 25, 2024

build

@res-life
Copy link
Collaborator Author

build

@res-life res-life merged commit 01c3003 into NVIDIA:branch-24.12 Sep 26, 2024
45 checks passed
@sameerz sameerz added the feature request New feature or request label Sep 26, 2024
@res-life res-life deleted the yyyymmdd-legacy branch September 27, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants