Check executor timezone is same as driver timezone when running on GPU #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
jlowe
reviewed
Nov 17, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
changed the title
jlowe
reviewed
Nov 18, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <[email protected]>
jlowe
reviewed
Nov 18, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuBatchScanExec.scala
Outdated
Show resolved
Hide resolved
jlowe
reviewed
Nov 18, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <[email protected]>
jlowe
approved these changes
Nov 18, 2021
|
build |
|
CI failure due to this error: I will upmerge and restart CI once #4139 gets merged which has the fix for above error. |
|
build |
1 similar comment
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3970
In this PR we are validating the executor timezone. If the driver timezone is supported to run on GPU, then we check if the executor timezone is also same. If executor timezone is different then we throw exception with the message to set executor timezone to match driver time zone.
Since it is reproducible only in cluster setup, I haven't added any tests. Verified this PR by running orc_test.py in YARN cluster.
Thanks @tgravescs for helping in debugging this issue.