Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support negative preceding/following for ROW-based window functions #9229

Merged
merged 17 commits into from
Sep 26, 2023
Merged

Support negative preceding/following for ROW-based window functions #9229

merged 17 commits into from
Sep 26, 2023

Commits on Sep 7, 2023

  1. Initial stab. Borked range windows.

    @mythrocks
    mythrocks committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    13356c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Kinda working-ish. 

    Explicit loops.
TODO: Replace comprehensions with maps.
    @mythrocks
    mythrocks committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e5ad4e9 View commit details
    Browse the repository at this point in the history

  2. With garbage collection for window options.

    @mythrocks
    mythrocks committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ed25eb6 View commit details
    Browse the repository at this point in the history

  3. Removed commented code, prints.

    @mythrocks
    mythrocks committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    350c1e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Most functions are working. 

    1. AVG is slightly off at high precision. @approx_decimal would be nice to have.
2. COLLECT_SET results don't match. Needs investigation.
    @mythrocks
    mythrocks committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    438e9b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Tests for grouped and ungrouped.

    @mythrocks
    mythrocks committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    839fb67 View commit details
    Browse the repository at this point in the history

  2. Parametrized grouped tests.

    @mythrocks
    mythrocks committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    bef04a0 View commit details
    Browse the repository at this point in the history

  3. Fixed ungrouped tests.

    @mythrocks
    mythrocks committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c6b79e5 View commit details
    Browse the repository at this point in the history

  4. Confine -ve offsets to supported operations. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    af167bb View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Support for COLLECT_SET.

    @mythrocks
    mythrocks committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fe4b0ab View commit details
    Browse the repository at this point in the history

  2. Moved minPeriods to GpuWindowFunction.

    @mythrocks
    mythrocks committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ef1bf77 View commit details
    Browse the repository at this point in the history

  3. Moved from explicit iteration to map.

    @mythrocks
    mythrocks committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8a3e546 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Add COLLECT_SET to test, instead of COLLECT_LIST.

    @mythrocks
    mythrocks committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    bcb833b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge remote-tracking branch 'origin/branch-23.10' into offset-row-wi… 

    …ndows-wip
    @mythrocks
    mythrocks committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    253f195 View commit details
    Browse the repository at this point in the history

  2. Fixed sign-check on lower bounds. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    55a3ec9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/branch-23.10' into offset-row-wi… 

    …ndows-wip
    @mythrocks
    mythrocks committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4734d61 View commit details
    Browse the repository at this point in the history

  4. Skip decimal test for large decimals on buggy Apache Spark versions. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8a11579 View commit details
    Browse the repository at this point in the history