Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins-level retry for pre-merge build in databricks runtimes [databricks] #9624

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Nov 3, 2023

We got more and more build failures while downloading dependencies since apache repos (central&sonatype) are quite unstable recently.

For CI running internally, we have URM artifactory but for external runs (like databricks) we can only try to add more retries and pray this could help mitigate the issue (we already have maven retry args but did not help too much). Managed cache on shared CSP storage could also be an option as long-term goal

This change only touches the build step. (internal pipeline has applied the same change)

@pxLi pxLi added the build Related to CI / CD or cleanly building label Nov 3, 2023
@pxLi pxLi force-pushed the more-retry-when-databricks branch from 2e15dec to d6abaa8 Compare November 3, 2023 07:21
@pxLi
Copy link
Collaborator Author

pxLi commented Nov 3, 2023

build

@pxLi pxLi changed the title Add jenkins-level retry for mvn build in databricks runtimes [databricks] Add jenkins-level retry for pre-merge build in databricks runtimes [databricks] Nov 3, 2023
Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxLi
Copy link
Collaborator Author

pxLi commented Nov 6, 2023

NIT: we could consider separating the dep download build part to save more time. but it requires some other investigation (some discussion in #9609)

@pxLi pxLi merged commit 68883ac into NVIDIA:branch-23.12 Nov 6, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants