Fully support date/time legacy rebase for nested input [databricks] #9660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
# Conflicts: # sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
…IA#9617)" This reverts commit 401d0d8. Signed-off-by: Nghia Truong <[email protected]> # Conflicts: # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
# Conflicts: # sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
# Conflicts: # integration_tests/src/main/python/parquet_test.py
# Conflicts: # integration_tests/src/main/python/parquet_test.py # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
the
task
ttnghia
changed the title
# Conflicts: # integration_tests/src/main/python/parquet_test.py # integration_tests/src/main/python/parquet_write_test.py # sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala # sql-plugin/src/main/scala/com/nvidia/spark/rapids/datetimeRebaseUtils.scala
ttnghia
commented
Nov 15, 2023
Comment on lines
-316
to
-317
| # Once https://github.com/NVIDIA/spark-rapids/issues/1126 is fixed delete this test and merge it | ||
| # into test_parquet_read_roundtrip_datetime |
There was a problem hiding this comment.
This deleted test is combined with the test_parquet_read_roundtrip_datetime.
ttnghia
commented
Nov 15, 2023
Comment on lines
+78
to
+83
| parquet_datetime_in_struct_gen = [ | ||
| StructGen([['child' + str(ind), sub_gen] for ind, sub_gen in enumerate(parquet_datetime_gen_simple)])] | ||
| parquet_datetime_in_array_gen = [ArrayGen(sub_gen, max_length=10) for sub_gen in | ||
| parquet_datetime_gen_simple + parquet_datetime_in_struct_gen] | ||
| parquet_nested_datetime_gen = parquet_datetime_gen_simple + parquet_datetime_in_struct_gen + \ | ||
| parquet_datetime_in_array_gen |
There was a problem hiding this comment.
Simplify the data generators a bit, since they are too heavy and the tests using them (especially in parquet read tests) become very very slow now.
Signed-off-by: Nghia Truong <[email protected]>
# Conflicts: # integration_tests/src/main/python/parquet_write_test.py
Signed-off-by: Nghia Truong <[email protected]>
|
build |
Signed-off-by: Nghia Truong <[email protected]>
revans2
previously approved these changes
Nov 15, 2023
|
build |
Signed-off-by: Nghia Truong <[email protected]>
|
build |
revans2
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds full support for date/time legacy rebase for the input containing dates/timestamps nested under other columns.
Most related tests are updated to reflect the changes.
Depends on:
spark.sql.parquet.datetimeRebaseModeInRead=LEGACYandspark.sql.parquet.int96RebaseModeInRead=LEGACY[databricks] #9649spark.sql.parquet.int96RebaseModeInWrite=LEGACY[databricks] #9658Closes #1126.
Warn: This PR contains code from the dependency PRs above and will be hidden after they are merged.