Encode the file path from Iceberg when converting to a PartitionedFile [databricks] #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Iceberg always gives the raw data path but rapids multi-file readers expect the file path is encoded and url safe. Signed-off-by: Firestarman <[email protected]>
|
build |
winningsix
reviewed
Nov 15, 2023
...ugin/src/main/java/com/nvidia/spark/rapids/iceberg/spark/source/GpuMultiFileBatchReader.java
Show resolved
Hide resolved
| Arrays.stream(pFiles).forEach(pFile -> { | ||
| String partFilePathString = pFile.filePath().toString(); | ||
| FileScanTask fst = files.get(partFilePathString); | ||
| FilteredParquetFileInfo filteredInfo = filterParquetBlocks(fst, partFilePathString); |
There was a problem hiding this comment.
nit: Let's add some comments why we need to pass in partFilePathString other than using fst.file().path().toString() to get it.
There was a problem hiding this comment.
We can use toEncodedPathString(fst) instead of this partFilePathString here, but I don't want to do this encoding again since we already have the encoded path string in the PartitionedFile.
winningsix
previously approved these changes
Nov 15, 2023
Signed-off-by: Firestarman <[email protected]>
|
build |
winningsix
approved these changes
Nov 15, 2023
jlowe
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9697
Iceberg always gives the raw data path but rapids multi-file readers expect the file path is encoded and url safe.
So this PR adds support to encode the file path string for Iceberg multi-files reads.