Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource leak in to_json #9879

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix resource leak in to_json #9879

merged 1 commit into from
Nov 29, 2023

Conversation

andygrove
Copy link
Contributor

Closes #9877

@andygrove andygrove added the bug Something isn't working label Nov 28, 2023
@andygrove andygrove self-assigned this Nov 28, 2023
@andygrove andygrove changed the base branch from branch-24.02 to branch-23.12 November 28, 2023 22:50
@andygrove
Copy link
Contributor Author

build

revans2
revans2 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem is that escapeJsonString didn't close the input.

@andygrove andygrove merged commit 31aee63 into NVIDIA:branch-23.12 Nov 29, 2023
38 checks passed
@andygrove andygrove deleted the to-json-resource-leak branch November 29, 2023 21:13
@andygrove andygrove mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 revans2 approved these changes

Assignees

@andygrove andygrove

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix resource leak in to_json
3 participants
@andygrove @jlowe @revans2