Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

MSVC does not define THRUST_CPP_DIALECT correctly #1030

Closed
bjude opened this issue Oct 29, 2019 · 2 comments
Closed

MSVC does not define THRUST_CPP_DIALECT correctly #1030

bjude opened this issue Oct 29, 2019 · 2 comments

Comments

@bjude
Copy link
Contributor

bjude commented Oct 29, 2019

MSVC always defines __cplusplus as 199711L, regardless of the standard mode, which means that THRUST_CPP_DIALECT will always be set to 2003.

#1028 attempted to work around this by using _MSVC_LANG to set THRUST_CPP_DIALECT correctly but ran into problems with MSVC's standard compliance on older versions MSVC regarding expression SFINAE.

@alliepiper
Copy link
Collaborator

Just to keep this issue updated -- there's a patch on the way that will update the dialect detection to use _MSVC_LANG instead of __cplusplus when defined and deprecate support for MSVC compilers that don't define it. This will effectively resolve this issue.

@alliepiper
Copy link
Collaborator

This has been addressed in #1089.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants