This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Define THRUST_CPP_DIALECT correctly under MSVC #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC doesnt define __cplusplus correctly unless a compiler flag is passed (/Zc:__cplusplus) but _MSVC_LANG is defined correctly. To avoid users needing to pass an extra compile flag, I suggest we handle it in the cpp_dialect.h file
|
Yep, this is a clear oversight. Running internal CI. @griwes to code review. |
brycelelbach
approved these changes
Oct 28, 2019
|
Passed internal CI. |
|
We had to revert this - what we need to do here is a bit more complicated, as MSVC isn't fully compliant (expression SFINAE) until newer versions. Can you open an issue to discuss this further? |
|
Damn, i only tested using VS2019. Issue #1030 created to track this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC doesnt define __cplusplus correctly unless a compiler flag is passed (/Zc:__cplusplus) but _MSVC_LANG is defined correctly.
To avoid users needing to pass an extra compile flag, I suggest we handle it in the cpp_dialect.h file