This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix regression in transform_inclusive_scan. #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
added
testing: internal ci in progress
|
DVS CL: 29294155 |
alliepiper
force-pushed
the
bug/transform_scan_regression/gh.1332
branch
2 times, most recently
from
b62d7ce
to
7bfb05a
Compare
|
New DVS CL: 29294189 |
brycelelbach
reviewed
Nov 9, 2020
brycelelbach
approved these changes
Nov 9, 2020
alliepiper
added
testing: gpuCI passed
We were deducing a reference type when we needed a value type for the transform iterator instantition. Fixes NVIDIA#1332 and adds a regression test.
alliepiper
force-pushed
the
bug/transform_scan_regression/gh.1332
branch
from
7bfb05a
to
8d50a02
Compare
|
New DVS CL: 29301755 |
alliepiper
added
testing: internal ci passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were deducing a reference type when we needed a value type for the
transform iterator instantition.
Fixes #1332 and adds a regression test.