This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix compilation error when a standard library type is wrapped in thrust::optional
#1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks for the patch! |
|
run tests |
alliepiper
added
the
testing: internal ci in progress
|
DVS CL: 29489327 |
alliepiper
added
testing: gpuCI in progress
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring a
thrust::optional<std::string>causes a following error:call of overloaded ‘addressof(std::__cxx11::basic_string<char>&)’ is ambiguousThis is because both
thrustandstdhaveaddressof(std::addressofis found through ADL).The patch is to simply explicitly use
thrust::addressofin this context. Verified locally to fix the issue.