This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 758
Sequence: Specialise compute_sequence_values for builtin arithmetic types #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
alliepiper
added
testing: gpuCI in progress
Started gpuCI testing.
testing: internal ci in progress
Currently testing on internal NVIDIA CI (DVS).
labels
Sep 21, 2021
Thanks for the patch, and sorry about the review delay! LGTM -- I just pushed a small fixup commit to add a missing newline. Starting tests now. DVS CL: 30441766 run tests |
There are some build failures to address before this is merged:
We also need to support C++11, so the
|
bjude
force-pushed
the
sequence_no_size_t_conversion
branch
2 times, most recently
from
September 22, 2021 00:15
7cf7855
to
8743aec
Compare
…ypes Only explicitly cast to T when we're dealing with builtin arithmetic types and just perform the `init + step * i` operation for all other types. This enables `thrust::sequence` to work for types without a conversion from `std::size_t`. Addresses issue NVIDIA#1498
(cherry picked from commit c4f4d59)
Thanks for the quick fix :) Restarting tests. DVS CL: 30452736 run tests |
alliepiper
suggested changes
Sep 29, 2021
alliepiper
removed
testing: internal ci in progress
Currently testing on internal NVIDIA CI (DVS).
testing: gpuCI in progress
Started gpuCI testing.
labels
Sep 29, 2021
Damn, that one didnt show up with MSVC, they seem to be a bit inconsistent with when the signed vs unsigned warning triggers. I'll get it fixed up today |
Thanks! DVS CL: 30482082 run tests |
alliepiper
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only explicitly cast to T when we're dealing with builtin arithmetic types and just perform the
init + step * i
operation for all other types. This enablesthrust::sequence
to work for types without a conversion fromstd::size_t
.Addresses issue #1498