Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Use CUB version of CUB adjacent difference #1512

Merged
merged 3 commits into from
May 9, 2022
Merged

Use CUB version of CUB adjacent difference #1512

merged 3 commits into from
May 9, 2022

Conversation

gevtushenko
Copy link
Collaborator

No description provided.

@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko
Copy link
Collaborator Author

DVS: 30346520

@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko gevtushenko force-pushed the main-feature/github/use_cub_adjacent_difference branch from c74587d to 92de4ec Compare August 27, 2021 09:53
@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko gevtushenko force-pushed the main-feature/github/use_cub_adjacent_difference branch from 92de4ec to 88902c2 Compare August 27, 2021 09:57
@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko gevtushenko force-pushed the main-feature/github/use_cub_adjacent_difference branch from 88902c2 to cc8e243 Compare August 27, 2021 15:38
@gevtushenko
Copy link
Collaborator Author

run tests

@alliepiper alliepiper self-assigned this Sep 21, 2021
@alliepiper alliepiper added P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Sep 21, 2021
@alliepiper alliepiper added this to the 1.15.0 milestone Sep 21, 2021
@alliepiper alliepiper modified the milestones: 1.15.0, 1.16.0 Oct 14, 2021
@alliepiper alliepiper added P2: nice to have Desired, but not necessary. and removed P1: should have Necessary, but not critical. labels Oct 14, 2021
@alliepiper alliepiper modified the milestones: 1.16.0, 1.17.0 Feb 7, 2022
alliepiper
alliepiper suggested changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're working on this, see if we can remove the #includes at the bottom of this file. The memory one should definitely be able to go.

thrust/system/cuda/detail/adjacent_difference.h Outdated Show resolved Hide resolved
thrust/system/cuda/detail/adjacent_difference.h Outdated Show resolved Hide resolved
thrust/system/cuda/detail/adjacent_difference.h Outdated Show resolved Hide resolved
thrust/system/cuda/detail/adjacent_difference.h Outdated Show resolved Hide resolved
thrust/system/cuda/detail/adjacent_difference.h Outdated Show resolved Hide resolved
thrust/system/cuda/detail/adjacent_difference.h Outdated Show resolved Hide resolved
@alliepiper alliepiper removed their assignment Apr 26, 2022
@alliepiper alliepiper added type: enhancement New feature or request. backend: CUDA Related to the CUDA backend and removed testing: gpuCI passed Passed gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Apr 26, 2022
@gevtushenko gevtushenko mentioned this pull request Apr 28, 2022
Merged
@gevtushenko gevtushenko force-pushed the main-feature/github/use_cub_adjacent_difference branch from cc8e243 to cf50b7d Compare May 6, 2022 16:50
@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko gevtushenko mentioned this pull request May 8, 2022
Merged
@alliepiper alliepiper merged commit 698c2f6 into NVIDIA:main May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees

@gevtushenko gevtushenko

Labels
backend: CUDA Related to the CUDA backend P2: nice to have Desired, but not necessary. type: enhancement New feature or request.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gevtushenko @alliepiper