This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix std::allocator traits #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
gevtushenko
force-pushed
the
main-bug/github/msvc_std_allocator
branch
from
8f17c03
to
926f092
Compare
gevtushenko
commented
Sep 8, 2021
gevtushenko
force-pushed
the
main-bug/github/msvc_std_allocator
branch
from
926f092
to
b822b8d
Compare
|
run tests |
|
LGTM, I tested this locally and it seems to work. Just run it through DVS and if it looks good, go ahead and merge it 👍 |
alliepiper
added
the
P0: must have
gevtushenko
force-pushed
the
main-bug/github/msvc_std_allocator
branch
from
b822b8d
to
c545f0a
Compare
gevtushenko
force-pushed
the
main-bug/github/msvc_std_allocator
branch
from
c545f0a
to
a9d907f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue.
SFINAE doesn't allow us to specialize code depending on the deprecation attribute. Therefore existing
allocator_traitsled to deprecated fields accesses. In this PR I explicitly specialized__THRUST_DEFINE_HAS_NESTED_TYPEforstd::allocatorin case of C++ >= 17.