Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rgba export / filter output based on occupancy grid #1433

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

ookey
Copy link
Contributor

@ookey ookey commented Aug 30, 2023

The Testbed::get_rgba_on_grid method enables to export rgba samples along a dense grid of the scene.
Only nerf_network::inference is used, thus keeping some points set to 0 in density grid.

This is as problem when the two info are different, eg if the latents in the empty zone have evolved due to collisions in the hashtables, or if the VR cleaning facility has been used.

This patch aims at setting to 0 all samples whose position is according to the density grid.

@Tom94
Copy link
Collaborator

Tom94 commented Sep 30, 2023

Thanks for the contribution! Looks good to me -- and apologies for the delay.

@Tom94 Tom94 merged commit db56177 into NVlabs:master Sep 30, 2023
13 checks passed
fnysalehi pushed a commit to fnysalehi/instant-ngp-rendering that referenced this pull request May 14, 2024
…port

Fix rgba export / filter output based on occupancy grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants