-
Notifications
You must be signed in to change notification settings - Fork 2
Integrate geocode into build #599
base: 563-Add-Devcontainer
Are you sure you want to change the base?
Conversation
…for geocode_hny and check work against final_devDB built with the old process
…e error, will ask Te for help
Also I save |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty cool! run it and worked on my machine. I am thinking whether one potential next step here is to run this branch on the github actions 1. to see if it works 2. create the qaqc file so we can plug into the app to see if the spatial stuff is roughly in line with the last few versions
went to look at the github actions run with this PR. I guess maybe the workflow needs some adjustment first?
also flagging that the mc installation is needed for devcontainer bash/config.sh: line 113: mc: command not found |
Ok word, so next steps are mini io installation and then run on github actions and review output on app? |
see my comments above the github actions seem not to be working for geocoding for some other reason as well. Didn't dig too deep to the cause |
This is a work in progress as I haven't gotten the docker compose run to work yet. I'm not stuck and it doesn't seem all that hard, I just hard to move to other things. |
Medium PR, could use a second reviewer if Max is interested 🌍
Addresses issues #597 and #598
Existing implementation
Currently the geocoding is done by the data sync action that sends the geocoded data to data library.
The downside of this implementation is that if the data sync hasn't been done recently, the data can be out of date. It's also hard to test changes.
New implementation
Geocode is run on our local machines from a devcontainer. I think this is better as having a linear pipeline that can be built in from one command is best practice
Changes to HNY
Inner join makes the
hny_devdb
table more readable