Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

sportowefakty.wp.pl #1760

Open
NanoMeow opened this issue Sep 1, 2019 · 40 comments
Open

sportowefakty.wp.pl #1760

NanoMeow opened this issue Sep 1, 2019 · 40 comments
Labels
s: sticky This issue is sticky or is difficult to resolve. No one is working on it right now. t: anti-adblock This issue was classified as anti-adblock.

Comments

@NanoMeow
Copy link
Owner

NanoMeow commented Sep 1, 2019

Basic Information

Test link: https://sportowefakty.wp.pl/
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.110 Safari/537.36 Vivaldi/2.7.1628.26
Extension: Nano Defender 15.0.0.165

Additional Message

Original URL: https://sportowefakty.wp.pl/zuzel/ps-poznan-stowarzyszenie

@NanoMeow NanoMeow added the s: untriaged This issue has not been triaged yet. label Sep 1, 2019
@krystian3w
Copy link

Enable AdGuard Base List as long uAsset no override:

#@#+js(set-constant, Object.prototype.bodies, true)
#@#+js(abort-on-property-read, WP.inline)

@jspenguin2017
Copy link
Collaborator

See: #1741

@jspenguin2017 jspenguin2017 added s: sticky This issue is sticky or is difficult to resolve. No one is working on it right now. t: anti-adblock This issue was classified as anti-adblock. and removed s: untriaged This issue has not been triaged yet. labels Sep 1, 2019
@okiehsch
Copy link

okiehsch commented Sep 2, 2019

Enable AdGuard Base List as long uAsset no override:
#@#+js(set-constant, Object.prototype.bodies, true)
#@#+js(abort-on-property-read, WP.inline)

In my opinion the polish list should remove those filters or keep them and add the AdGuard Base List filters.

@krystian3w
Copy link

krystian3w commented Sep 2, 2019

So Poland must copy all 27k filters? OMG...

I suppose AdGurad no remove ads with procedural filtering, to disable:

#@#+js(set-constant, Object.prototype.bodies, true)
#@#+js(abort-on-property-read, WP.inline)

First exsist in similar syntax (get prototype used) in AG base.

Second maybe created by uAssets in 2017 if also no copied from AG with translate.

@okiehsch
Copy link

okiehsch commented Sep 2, 2019

So Poland must copy all 27k filters? OMG...

No, they should remove their

#@#+js(set-constant, Object.prototype.bodies, true)
#@#+js(abort-on-property-read, WP.inline)

filters because it triggers the anti adblock warning.

@krystian3w
Copy link

krystian3w commented Sep 2, 2019

but comeback 99% one day ads - no better try allow 2-3 google ads files and maybe two EasyList bait cosmetic filters?

AdGuard fix in this method without disable scriplet from MajkiIT repo. Also no see in logger action to remove pop-up with procedural :has(...) filtering by AdGuard Base.
Olegwukr newer write any post in topic why no added all propose solutions.

@okiehsch
Copy link

okiehsch commented Sep 2, 2019

Well, right now the only thing users of the polish list see is an anti adblock message.

I am pretty sure they would prefer a solution that would let them actually use the site.

@krystian3w
Copy link

No, is not useable with unlocked ads. Too much in XXI centaury.

@gorhill possible for Poland enable AG base in uBO 1.22.x or 1.23?

@okiehsch
Copy link

okiehsch commented Sep 2, 2019

If the site works for you if you enable AdGuard base why not adding the relevant filters of that list to the polish list?

@krystian3w
Copy link

krystian3w commented Sep 2, 2019

Because nobody follow AdamWr commits added to AdGuard Base and logger uBo may no show all excptions (example fast bait on naekranie.pl no visible in uBo logger or need very luck).

@krystian3w
Copy link

And hard working with Olegwukr if no tell nothing more as commits with copied 2 form 6 filters.

@NanoMeow
Copy link
Owner Author

NanoMeow commented Sep 2, 2019

Basic Information

Test link: https://sportowefakty.wp.pl/boks-zawodowy/841075/boks-watpliwosci-ws-dawida-kosteckiego-opinia-bieglego-obala-wersje-romana-giert
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.110 Safari/537.36 Vivaldi/2.7.1628.30
Extension: Nano Defender 15.0.0.166

Additional Message

@NanoMeow
Copy link
Owner Author

NanoMeow commented Sep 2, 2019

Basic Information

Test link: https://sportowefakty.wp.pl/zuzel
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.110 Safari/537.36 Vivaldi/2.7.1628.26
Extension: Nano Defender 15.0.0.166

Additional Message

@okiehsch
Copy link

okiehsch commented Sep 2, 2019

@MajkiIT

For the anti-adblock messages at
o2.pl,pudelek.pl,wp.pl
caused by your filters
adding

@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$domain=o2.pl|pudelek.pl|wp.pl
wp.pl#@#body > div:nth-of-type(1)[style^="display: block;"]:not(#page)
o2.pl,pudelek.pl,wp.pl#@#.pub_300x250
o2.pl,pudelek.pl,wp.pl#@#.text_ads

fixes the issue on my end.

@MajkiIT
Copy link

MajkiIT commented Sep 3, 2019

@okiehsch Unfortinatly not working :(

@krystian3w
Copy link

krystian3w commented Sep 3, 2019

WP something changed now, no help also AG base List.

@krystian3w
Copy link

krystian3w commented Sep 3, 2019

I see bug - who merege 2 lines into 1:

obraz

@NanoMeow
Copy link
Owner Author

Basic Information

Test link: https://sportowefakty.wp.pl/zuzel
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.62 Safari/537.36 Vivaldi/2.8.1657.8
Extension: Nano Defender 15.0.0.168

Additional Message

okiehsch added a commit to uBlockOrigin/uAssets that referenced this issue Sep 19, 2019
@okiehsch
Copy link

Well, right now the only thing users of the polish list see is an anti adblock message.
I am pretty sure they would prefer a solution that would let them actually use the site.

This is still the case three weeks later, so I have disabled those filters in uBO-filters.

@krystian3w
Copy link

So also update heavy ads (random class, URL, position in DOM).

@okiehsch
Copy link

I don't see any ads with the polish list enabled on my end.

@krystian3w
Copy link

krystian3w commented Sep 20, 2019

On homepage:

obraz
obraz
obraz
obraz

Placeholders

@krystian3w
Copy link

krystian3w commented Sep 22, 2019

Exceptions die, again detect uBO:

https://finanse.wp.pl/jadlam-ze-smietnikow-nie-uwierzycie-ile-tam-skarbow-6426560515410049a

@okiehsch
Copy link

@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$script,domain=wp.pl
wp.pl#@#body > div:nth-of-type(1)[style^="display: block;"]:not(#page)
pl#@#.ads

@NanoMeow
Copy link
Owner Author

Basic Information

Test link: https://sportowefakty.wp.pl
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0
Extension: Nano Defender 15.0.0.170

Additional Message

Original URL: https://sportowefakty.wp.pl/skoki-narciarskie/855637/ps-w-skokach-kosmiczny-lot-jana-hoerla-na-bergisel-skoczek-coraz-smielej-daje-o-

@krystian3w
Copy link

Unlock read or block placeholders...

WP follow moddification in Polish Repository...

@NanoMeow
Copy link
Owner Author

Basic Information

Test link: https://sportowefakty.wp.pl/
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.62 Safari/537.36 Vivaldi/2.8.1657.8
Extension: Nano Defender 15.0.0.170

Additional Message

@lain566
Copy link

lain566 commented Dec 1, 2019

I don't get anti adblock warning, but the site is broken if I enable Polish regional filter lists.

@krystian3w
Copy link

krystian3w commented Dec 1, 2019

Yeah WP update in few hours Object.prototype varible after commit on Polish repository.

Bad:

portal.abczdrowie.pl,parenting.pl,kafeteria.pl,dobreprogramy.pl,o2.pl,pudelek.pl,wp.pl#@#+js(set-constant.js, Object.prototype.rekid, undefined)

AdguardTeam/AdguardFilters#44613 (comment)

Latest is:

~www.wp.pl,gadzetomania.pl,komorkomania.pl,portal.abczdrowie.pl,parenting.pl,dobreprogramy.pl,o2.pl,pudelek.pl,wp.pl#%#//scriptlet("set-constant", "Object.prototype.rebuild", "undefined")

The Polish repository currently does not have a good JavaScript specialist to update this variable every 2-4 days.

Apparently, if you don't copy from AdGuard, the script filter for AdGuard users can works even for 2 weeks.

@krystian3w
Copy link

krystian3w commented Dec 1, 2019

When removing a message from the cosmetic procedure filter:

  • :has(),
  • :has-text(),
  • :matches-css...(),
  • :xpath()

they also know how to block pop-up removal:

  • change images,
  • CSS values,
  • text is created with pseudoelements (with invisible characters).

Also overlay-buster sometimes generate blank pages - so also bad.

@lain566
Copy link

lain566 commented Dec 1, 2019

@krystian3w I mean, for example ....

https://sportowefakty.wp.pl/sportowybar/wideo/36279/dziejesiewsporcie-sagan-dal-autograf-w-trakcie-wyscigu

If you go to this page, with the Polish filter lists enabled, the player will not load. It seems that someone thought it was a good idea to hide the cookie notice.

@krystian3w
Copy link

krystian3w commented Dec 1, 2019

It seems that someone thought it was a good idea to hide the cookie notice.

Cookies pop-up no possible hide, accept or not loaded video:

Polish solution with Addon: https://github.com/PolishFiltersTeam/PolishCookieConsent

The pop-up and player scripts lock each other out until the pop-up html code disappears from the html source/dom tree.

AdGuard also accept with custom script (not snippet / scriplet resource):

AdguardTeam/AdguardFilters#42536
AdguardTeam/AdguardFilters@0bf7f88
AdguardTeam/AdguardFilters@366505b

o2.pl,pudelek.pl,wp.pl#%#AG_onLoad(function(){if(-1==document.cookie.indexOf("WPdp")){var a=new MutationObserver(function(){var b=document.evaluate("//button[contains(text(), 'PRZECHODZ')]",document,null,XPathResult.ANY_TYPE,null).iterateNext();b&&(b.click(),a.disconnect())});a.observe(document,{childList:!0,subtree:!0});setTimeout(function(){a.disconnect()},1E4)}});
AG_onLoad(function() {
    if (-1 == document.cookie.indexOf("WPdp")) {
        var a = new MutationObserver(function() {
            var b = document.evaluate("//button[contains(text(), 'PRZECHODZ')]", document, null, XPathResult.ANY_TYPE, null).iterateNext();
            b && (b.click(), a.disconnect())
        });
        a.observe(document, {
            childList: !0,
            subtree: !0
        });
        setTimeout(function() {
            a.disconnect()
        }, 1E4)
    }
});

See: NanoAdblocker/NanoFilters#362

@lain566
Copy link

lain566 commented Dec 1, 2019

Anyway, there are more broken things on the page, this was one of them.

@krystian3w
Copy link

Again you broke header?

@lain566
Copy link

lain566 commented Dec 1, 2019

As I said before

the site is broken if I enable Polish regional filter lists.

@krystian3w
Copy link

unsubrcibe please.

@lain566
Copy link

lain566 commented Dec 1, 2019

unsubrcibe please.

I only subscribed to be able to fix anti adblock, the breakages of the site that I mentioned before, is for you to know, and you can fix it, I'm sorry if my words sound hard, and I understand, everyone is wrong, nobody is perfect.

Repository owner locked and limited conversation to collaborators Dec 1, 2019
@jspenguin2017
Copy link
Collaborator

This issue is sticky and we are not getting anywhere in term of finding a durable solution. The conversation is becoming unconstructive, locking.

@NanoMeow
Copy link
Owner Author

Basic Information

Test link: https://sportowefakty.wp.pl/pilka-nozna/860558/adam-buksa-w-szatni-new-england-revolution-z-jezykiem-nie-ma-zadnego-problemu?src01=6a4c8&fbclid=IwAR2KoeKEWjwsidQdD-7cPl4Pktxg2bGDHOgoaFvM-TeZX2ndQGQpHgZaYSg
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.79 Safari/537.36
Extension: Nano Defender 15.0.0.170

Additional Message

@NanoMeow
Copy link
Owner Author

Basic Information

Test link: https://sportowefakty.wp.pl/pilka-nozna/860370/grzegorz-rasiak-pilka-ma-krotka-pamiec?utm_campaign=sgf&utm_medium=sf&utm_source=fb
Category: anti-adblock
Reported from: Poland
Template version: 2

User Environment

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.79 Safari/537.36
Extension: Nano Defender 15.0.0.170

Additional Message

Repository owner unlocked this conversation Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s: sticky This issue is sticky or is difficult to resolve. No one is working on it right now. t: anti-adblock This issue was classified as anti-adblock.
Projects
None yet
Development

No branches or pull requests

6 participants