Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning for joblib in scikit #275

Merged
merged 1 commit into from
May 14, 2019

Conversation

kinow
Copy link
Collaborator

@kinow kinow commented May 12, 2019

Following the documentation and noticed the following warning:

/home/kinow/Development/python/workspace/Annif/venv/lib/python3.7/site-packages/sklearn/externals/joblib/__init__.py:15: DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. Please import this functionality directly from joblib, which can be installed with: pip install joblib. If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.
  warnings.warn(msg, category=DeprecationWarning)

Not seen when running pytest.

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          52       52           
  Lines        2624     2624           
=======================================
  Hits         2606     2606           
  Misses         18       18
Impacted Files Coverage Δ
annif/project.py 100% <100%> (ø) ⬆️
annif/backend/pav.py 98.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1381806...805d4a7. Read the comment docs.

@osma osma added this to the v0.41 milestone May 14, 2019
@osma osma added the bug label May 14, 2019
@osma osma merged commit 1e9bdc9 into NatLibFi:master May 14, 2019
@osma
Copy link
Member

osma commented May 14, 2019

Thanks @kinow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants