Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LMDB map size a configurable parameter for nn_ensemble backend. #554

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

mo-fu
Copy link
Contributor

@mo-fu mo-fu commented Jan 18, 2022

This PR adds the simple solution to close #552, as discussed in the issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma
Copy link
Member

osma commented Jan 18, 2022

Great! Can we say this fixes #552 (to auto-close the issue when this is merged)? I think it has to be stated in the opening post to be effective.

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #554 (6313081) into master (ccb9982) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          80       80           
  Lines        5340     5349    +9     
=======================================
+ Hits         5313     5322    +9     
  Misses         27       27           
Impacted Files Coverage Δ
annif/backend/nn_ensemble.py 99.25% <100.00%> (-0.01%) ⬇️
tests/test_backend_nn_ensemble.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb9982...6313081. Read the comment docs.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osma osma merged commit f34f2a9 into NatLibFi:master Jan 18, 2022
@osma
Copy link
Member

osma commented Jan 18, 2022

Merged, thanks a lot @mo-fu !

@osma osma added this to the 0.56 milestone Jan 18, 2022
@osma osma added the bug label Jan 18, 2022
@osma
Copy link
Member

osma commented Jan 21, 2022

As we are nearing the 0.56 release, I added some documentation about this setting to the wiki page of the NN ensemble backend - see this diff for the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LMDB can overflow
2 participants