Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importlib_metadata regular dependency #580

Closed
wants to merge 1 commit into from

Conversation

juhoinkinen
Copy link
Member

When some DeprecationWarnings of unit tests were resolved in #575, I put importlib_metadata installation under dev dependencies, but it should be a regular dependency.

@juhoinkinen juhoinkinen added this to the 0.57 milestone Mar 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma
Copy link
Member

osma commented Mar 14, 2022

Can you clarify why it should be a regular dependency?

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #580 (b2d3ad2) into master (3629139) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          84       84           
  Lines        5568     5568           
=======================================
  Hits         5539     5539           
  Misses         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3629139...b2d3ad2. Read the comment docs.

@juhoinkinen
Copy link
Member Author

Uups, now when I checked why it should be a regular dependency, I see no reason.

I thought that importlib_metadata was used in the annif --version CLI option, but it is not; it is used only in testing it, so it should remain as a dev dependency.

I'll close this, thanks for questioning :)

@juhoinkinen juhoinkinen removed this from the 0.57 milestone Mar 14, 2022
@juhoinkinen juhoinkinen deleted the importlib-metadata-to-regular-dependency branch August 17, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants