Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to joblib 1.2.x #627

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Upgrade to joblib 1.2.x #627

merged 1 commit into from
Oct 3, 2022

Conversation

osma
Copy link
Member

@osma osma commented Oct 3, 2022

This PR upgrades joblib from 1.1.0 to 1.2.*. The main reason is to get rid of the dependabot warning about an arbitrary code execution security vulnerability.

AFAICT, Annif isn't actually vulnerable because we don't use the pre_dispatch option at all.

@osma osma added this to the 0.60 milestone Oct 3, 2022
@osma osma self-assigned this Oct 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 99.61% // Head: 99.61% // No change to project coverage 👍

Coverage data is based on head (5a603ad) compared to base (6e5a939).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          87       87           
  Lines        5945     5945           
=======================================
  Hits         5922     5922           
  Misses         23       23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osma osma marked this pull request as ready for review October 3, 2022 08:51
@osma osma merged commit 597e67e into master Oct 3, 2022
@osma osma deleted the upgrade-joblib-1.2 branch October 3, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant