Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate codestyle to Black v23 #668

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Migrate codestyle to Black v23 #668

merged 2 commits into from
Feb 3, 2023

Conversation

juhoinkinen
Copy link
Member

Black v23.1 was released recently, and as their Stability Policy states, Black style is allowed to change between yearly/major Black releases.

To avoid surprising failures in CI/CD, this pins the Black version.

The code style change to v23 luckily just removes a few empty lines.

@juhoinkinen juhoinkinen added this to the 0.61 milestone Feb 3, 2023
@juhoinkinen juhoinkinen changed the title Migrate codestyle to Black v23.1 Migrate codestyle to Black v23 Feb 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 99.56% // Head: 95.76% // Decreases project coverage by -3.80% ⚠️

Coverage data is based on head (a7e3b4b) compared to base (4b03e79).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   99.56%   95.76%   -3.80%     
==========================================
  Files          87       87              
  Lines        6143     6143              
==========================================
- Hits         6116     5883     -233     
- Misses         27      260     +233     
Impacted Files Coverage Δ
annif/backend/pav.py 98.87% <ø> (ø)
annif/backend/stwfsa.py 100.00% <ø> (ø)
annif/lexical/mllm.py 100.00% <ø> (ø)
annif/transform/inputlimiter.py 100.00% <ø> (ø)
annif/transform/langfilter.py 100.00% <ø> (ø)
tests/test_exception.py 100.00% <ø> (ø)
annif/backend/fasttext.py 3.44% <0.00%> (-96.56%) ⬇️
tests/test_backend_fasttext.py 7.05% <0.00%> (-92.95%) ⬇️
tests/test_analyzer_spacy.py 20.00% <0.00%> (-80.00%) ⬇️
annif/analyzer/spacy.py 36.36% <0.00%> (-63.64%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juhoinkinen juhoinkinen merged commit 4a55a34 into master Feb 3, 2023
@juhoinkinen juhoinkinen deleted the run-black-v23 branch February 3, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant