Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and cleanup CLI module #675

Merged
merged 8 commits into from
Mar 13, 2023
Merged

Conversation

@juhoinkinen juhoinkinen added this to the 0.61 milestone Feb 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 99.56% // Head: 99.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d1a5043) compared to base (3e8f42f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          87       88    +1     
  Lines        6158     6171   +13     
=======================================
+ Hits         6131     6144   +13     
  Misses         27       27           
Impacted Files Coverage Δ
annif/cli.py 99.62% <100.00%> (-0.08%) ⬇️
annif/cli_util.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juhoinkinen juhoinkinen marked this pull request as ready for review February 22, 2023 07:38
@juhoinkinen juhoinkinen merged commit e9fd177 into main Mar 13, 2023
@juhoinkinen juhoinkinen deleted the refactor-cli-helper-functions branch March 13, 2023 12:18
juhoinkinen added a commit that referenced this pull request Mar 20, 2023
juhoinkinen added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant