-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve outputs of project inspection CLI commands #694
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 89 89
Lines 6222 6253 +31
=======================================
+ Hits 6199 6230 +31
Misses 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dirpath = os.path.join(str(testdatadir), "projects", "tfidf-fi") | ||
fpath = os.path.join(str(dirpath), "test_show_project_datafile") | ||
os.makedirs(dirpath) | ||
open(fpath, "a").close() |
Check warning
Code scanning / CodeQL
File is not always closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a false warning.
I started to think adding also "Backend" column to the output of |
list-projects
Yet another addition would be to dump project configuration to output of Other possible items to be added to the |
The output for project configuration could be like this (hiding the parameters that are already shown by the above lines):
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe simplest would be to merge this as it is now, then possibly work on the project configuration display in a follow-up PR? |
Makes the column widths of the output of
annif list-projects
andannif list-vocabs
dynamic to not spend unnecessary space in terminal. For vocabularies the benefit of this is not so great, but implementing this for both listing commands keeps the functionalities aligned. The separator for columns is 2 spaces.Adds vocabulary ID and modification time columns to the output of
list-projects
implementing issue CLI commandlist-projects
fields #686.Converts the project modification timestamps to current timezone (from UTC) and formats them to YYYY-MM-DD hh:mm:ss in the outputs of
list-projects
andshow-project
, using-
in place ofNone
.Adds "Backend" line the output of
show-project
An example output of
list-projects
:An example output of
list-vocabs
:An example output of
show-project
: