-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 support #727
Python 3.11 support #727
Conversation
Old method trial.suggest_uniform() is deprecated
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6380 6400 +20
=======================================
+ Hits 6359 6379 +20
Misses 21 21
☔ View full report in Codecov by Sentry. |
If the unit tests pass on Python 3.11 (except Omikuji, but that is not even installed for 3.11), then I don't see why we should mark the CI tests as experimental. It would be a different situation if some core tests were failing on 3.11 and we couldn't fix them right now. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The Python 3.11 parts of this PR look good to me, but since this includes all the commits from PR #726, we need to make sure those are good as well before merging this. I noticed a potential problem with TF/Keras, see #726 (comment) |
Allow installing Annif on Python 3.11, and run unit tests on it in the CI/CD pipeline.
Omikuji dependency does not work Python 3.11, see #703 (comment). Other dependencies seem to work (i.e. the unit tests pass).
tomli
is now a (direct) dependency only on Python <3.11, on Python 3.11tomllib
of standard library is used instead (PEP 690). However, also on Python 3.11tomli
is still installed as it is a dependency ofblack
,coverage
,pytest
andschemathesis
.Closes #703, includes merge of the branch of #726.