Show Annif version in WebUI #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6404 6404
=======================================
Hits 6383 6383
Misses 21 21 ☔ View full report in Codecov by Sentry. |
|
Looks very good, but is it clear enough with only the version number? Would it be better to say "Annif v1.1.0" or something along those lines... |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to know which version of Annif is running for the Web UI.
This PR adds a version number string, e.g.
Annif v1.1.0(orAnnif v1.1.0.dev0for the development version) outside the text box in the lower right corner, see screenshot below.An alternative position for the version number could be just below "Web UI" title in the header, but the position of this PR is the same as will be in Finto AI.