Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and Docker rebuild due to defunct Schemathesis and pytest dependencies resolution #767

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

juhoinkinen
Copy link
Member

Pytest 8.0.0 was released on 2014-01-17. Lately Schemathesis releases have been pinning pytest to <=8, and as Poetry favored pytest over Schemathesis in version resolution, pytest 8 and Schemathesis 3.14.2 (version just before pytest <=8 pinning) are now being installed.

The problem is that tests (and thus Docker rebuild) do not work with this ancient Schemathesis version:

...
RuntimeError: The starlette.testclient module requires the httpx package to be installed.
You can install this with:
    $ pip install httpx 

This is fixed by pinning to pytest 7.*.* in Annif.

@juhoinkinen juhoinkinen added the dependencies Pull requests that update a dependency file label Feb 2, 2024
@juhoinkinen juhoinkinen added this to the 1.1 milestone Feb 2, 2024
pyproject.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7ecfd2) 99.67% compared to head (a23e18b) 99.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          89       89           
  Lines        6404     6404           
=======================================
  Hits         6383     6383           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@juhoinkinen juhoinkinen merged commit 538bb16 into main Feb 2, 2024
16 of 17 checks passed
juhoinkinen added a commit that referenced this pull request Feb 2, 2024
@juhoinkinen juhoinkinen added the bug label Feb 2, 2024
@Stranger6667
Copy link

FYI. I am going to add Pytest 8.0 support in Schemathesis soon

juhoinkinen added a commit to juhoinkinen/Annif that referenced this pull request Mar 8, 2024
@juhoinkinen juhoinkinen deleted the fix-tests-pin-to-pytest7 branch April 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants