-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informational error message for failed loading of nn-ensemble model #785
Add informational error message for failed loading of nn-ensemble model #785
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.01%
==========================================
Files 89 91 +2
Lines 6405 6817 +412
==========================================
+ Hits 6383 6793 +410
- Misses 22 24 +2 ☔ View full report in Codecov by Sentry. |
I'm actually unsure if I'm using the error message prefix formatting correctly or is it not working? Now the beginning part is a bit weird in the message:
|
I agree it looks weird, but it's formatted here: Lines 35 to 37 in 1b201dc
|
The test for the failed reading of metadata from model file does not pass in CICD on Python 3.9, while it passes on Python 3.11 and on my laptop. The issue is in log capturing:
The log message is not so important to test, so I'll just remove the assert for it. |
Quality Gate passedIssues Measures |
The new error message shows
See for example the last line of the following:
Closes #784.