Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css fixes of the landing page vocab list #1669

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Css fixes of the landing page vocab list #1669

merged 2 commits into from
Oct 2, 2024

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Aug 22, 2024

This PR is built on #1668

Reasons for creating this PR

Fixes for the vocabulary list on the landing page

Description of the changes in this PR

  • Fixed the styling for category headings on the landing page
  • Fixed the styling for vocabulary list links on the landing page

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

Copy link

sonarcloud bot commented Aug 22, 2024

@joelit joelit changed the base branch from main to issue1653-twig-templates-into-their-own-classes August 22, 2024 13:44
@joelit joelit changed the base branch from issue1653-twig-templates-into-their-own-classes to main August 22, 2024 13:45
@joelit joelit self-assigned this Aug 22, 2024
@joelit joelit added this to the 3.0 milestone Aug 22, 2024
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, but there should be a margin/padding after each .vocab-category.

There are again some lines in skosmos.css that can be removed (397-399). Also, the .vocabulary-list definitions at the bottom should be moved up with the rest of the vocab list definitions.

resource/css/skosmos.css Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joelit joelit merged commit 3386c6d into main Oct 2, 2024
10 checks passed
@joelit joelit deleted the css-fix-vocab-list branch October 2, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants