Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't HTML encode quotes in REST API callback, to fix ONKI Selector (Skosmos 3) #1706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

osma
Copy link
Member

@osma osma commented Oct 29, 2024

Reasons for creating this PR

See PR #1705. This is the same fix but for Skosmos 3.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Oct 29, 2024
@osma osma self-assigned this Oct 29, 2024
Copy link

sonarcloud bot commented Oct 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

1 participant