Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequencing report service #230

Conversation

Aratz
Copy link
Contributor

@Aratz Aratz commented Mar 13, 2024

This PR updates the sequencing report service and adds nf-core/demultiplex to the deployment

This new version contains many new features but for this release we will only validate it can still work as before.

@Aratz Aratz requested review from b97pla and slohse March 13, 2024 12:43
@Aratz Aratz self-assigned this Mar 13, 2024
Copy link
Contributor

@b97pla b97pla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work!

I had a few question/comments.

Also, I think bimonthly is behind monthly. If possible to bring it up-to-date, I think the PR would be much cleaner.

@Aratz Aratz force-pushed the DEVELOP-2650_add_nf-core_demultiplex branch 5 times, most recently from c153ad0 to 11e05e2 Compare April 4, 2024 13:37
@Aratz
Copy link
Contributor Author

Aratz commented Apr 5, 2024

Thanks for the reviews! I'll make a separate PR to update bimonthly, hopefully this makes this one clearer, otherwise, I'll close it and open a new one.

@Aratz Aratz force-pushed the DEVELOP-2650_add_nf-core_demultiplex branch from 32a1e4f to 05e5801 Compare April 5, 2024 14:05
@Aratz Aratz requested review from matrulda and b97pla April 5, 2024 14:06
Copy link
Member

@matrulda matrulda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I left some comments for you.

Copy link
Contributor

@b97pla b97pla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me

@Aratz Aratz changed the base branch from bimonthly to monthly April 22, 2024 10:56
@Aratz Aratz force-pushed the DEVELOP-2650_add_nf-core_demultiplex branch from fdb373c to 4f2d976 Compare April 22, 2024 11:00
@Aratz Aratz merged commit 51ec205 into NationalGenomicsInfrastructure:monthly Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants