Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast PCM Encoding #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FalconPDX
Copy link
Collaborator

@FalconPDX FalconPDX commented Jan 14, 2024

Uses the pcm library to encode a range instead of each element in a range. Makes encoding much faster.

This is a first of three different packages - starting off with the smallest. The other two (refactor of the ofstream interface + FLAC encoding) will come at a later time in the form of a "stacked PR". This gives users a chance to try out the individual pieces and potentially find issues quicker at the cost of repeated testing.

The other two PRs:
ofstream refactor: FalconPDX#3
FLAC encoding: FalconPDX#4

@FalconPDX FalconPDX added the ofstream ofstream improvements label Jan 14, 2024
@FalconPDX FalconPDX self-assigned this Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (89eb1e3) 83.10% compared to head (f10b034) 83.00%.

Files Patch % Lines
audiostream/inc/ni/media/audio/ostream.h 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   83.10%   83.00%   -0.10%     
==========================================
  Files          82       82              
  Lines        2024     2030       +6     
==========================================
+ Hits         1682     1685       +3     
- Misses        342      345       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ofstream ofstream improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant