Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Add print-to-pdf endpoint #12

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Add print-to-pdf endpoint #12

merged 3 commits into from
Aug 3, 2023

Conversation

basst85
Copy link
Contributor

@basst85 basst85 commented Aug 1, 2023

Add support for direct print to PDF-file.

@mpociot
Copy link
Member

mpociot commented Aug 1, 2023

Thank you for the PR. Could you change it so that instead of writing the file, it returns the file as a response?
Then we can return that file in the PHP API and the user can decide what they want to do with it - and potentially save it.

@basst85
Copy link
Contributor Author

basst85 commented Aug 2, 2023

Thank you for the PR. Could you change it so that instead of writing the file, it returns the file as a response? Then we can return that file in the PHP API and the user can decide what they want to do with it - and potentially save it.

Should I return the PDF-data as a base64 encoded string?

@mpociot
Copy link
Member

mpociot commented Aug 2, 2023

Yeah I think this would be the easiest option

@basst85
Copy link
Contributor Author

basst85 commented Aug 2, 2023

Yeah I think this would be the easiest option

Ok 👍 Changed it.

@mpociot mpociot merged commit 872895d into NativePHP:main Aug 3, 2023
1 check failed
@mpociot
Copy link
Member

mpociot commented Aug 3, 2023

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants