-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hindi Aggressive Tokenizer #693
Conversation
aggressive tokenization hindi added
corrected test title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restrict the copyright notice to the file you authored. Now it says that you authored the aggressive tokenizer as a whole. Also remove the line with "Aggressive Tokenization Open-Source License (Version 1.0)" That is not an actually existing license. We are using MIT license.
Otherwise your license text is compatible with MIT license.
Thanks @Hugo-ter-Doest for your inputs, |
Pull Request Test Coverage Report for Build 5983185211Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Thanks for your contribution! Very nice to have a Hindi tokenizer as part of the natural library. |
Welcome ! I will try adding more contributions ahead. |
FYI I added the Hindi tokenizer to the API (index.js and index.d.ts files) and added it to the documentation at https://naturalnode.github.io/natural/ |
Hindi Language aggressive tokenizer.
I request fellow maintainers and contributors to review and merge my PR or raise queries or suggest changes.
I would highly appreciate inputs.
Thanks in Advance.