Fix: allow deposit to be called by any account #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
approved these changes
Mar 20, 2023
aleksuss
approved these changes
Mar 20, 2023
I guess it's an excellent point for adding related tests 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we no longer have any notion of deposit relayer or fee the
depositfunction does not make use ofpredecessor_id(except to check if the caller is the owner in the pausing logic). Therefore I think it is safe to open up this function to any account, not just the Aurora Engine. I think it also important that we do this so that thedepositfunction in Aurora Engine can be deprecated and eventually removed when it is no longer used (e.g. by the bridge).