Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: use aurora-workspace as a testing framework #28

Merged
merged 13 commits into from
May 11, 2023

Conversation

mrLSD
Copy link
Collaborator

@mrLSD mrLSD commented May 2, 2023

Description

Use aurora-workspace as a testing framework.

Motivation

To simplify aurora-eth-connector testing and unify the testing process used aurora-workspace library.

@mrLSD mrLSD self-assigned this May 2, 2023
@mrLSD mrLSD marked this pull request as draft May 2, 2023 14:39
@mrLSD mrLSD added this to the v0.4.2 milestone May 2, 2023
@mrLSD mrLSD added the tests label May 2, 2023
@mrLSD mrLSD modified the milestones: v0.4.2, v0.5.1 May 5, 2023
@mrLSD mrLSD marked this pull request as ready for review May 5, 2023 10:56
@mrLSD mrLSD added the do-not-merge Do not merge PR label May 5, 2023
Copy link
Collaborator

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but with a couple of nitpicks.

eth-connector-tests/src/connector.rs Show resolved Hide resolved
eth-connector-tests/src/utils.rs Outdated Show resolved Hide resolved
@mrLSD mrLSD merged commit 0f41bfe into master May 11, 2023
@mrLSD mrLSD deleted the feat/aurora-workspace branch May 11, 2023 21:20
@mrLSD mrLSD removed the do-not-merge Do not merge PR label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants