Implement ft_transfer_call on withdraw
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test for transfer to aurora? @karim-en |
kiseln
approved these changes
May 7, 2024
For that, we need to implement integration tests for this contract, which is out of the scope of this PR. |
olga24912
approved these changes
May 9, 2024
karim-en
force-pushed
the
ft-transfer-call
branch
from
bbda2b3
to
f129872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, it is not possible to transfer the Near tokens to the Aurora network directly because the contract doesn't implement the
ft_transfer_callon withdrawal.This PR adds the possibility of transferring the Near tokens from the Ethereum network to the Aurora network.
How it works:
<target_Account_id>:<msg>. The msg could be any message, but for Aurora network, it will be 20 bytes hex address.msgis attached, the contract wraps the native near tokens and transfers them to the target account ID.msgis None, then the contract transfers the Near tokens directly to the target as it has been done before.