[OmniBridge]: Support bind token #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have code stashed somewhere that allows us to lookup the event based on the signature (had to drop the work due to other urgent tasks). I suggest we bring it back and get rid of supplying indexes altogether Edit: here #38 |
kiseln
requested changes
Oct 8, 2024
| @@ -424,6 +426,66 @@ impl OmniConnector { | |||
| Ok(outcome) | |||
| } | |||
|
|
|||
| pub async fn bind_token_eth_evm_prover( | |||
There was a problem hiding this comment.
Not sure I understand the naming of this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the ability to call bind token in NEP141-locker. Added the ability to extract proof by tx_hash and log_index_in_receipt for convenience in tests.