feat(diagnostics): better detect BT devices and LTE devices #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posterzh
changed the title
marvinmarnold
suggested changes
Nov 26, 2021
docker-compose.yml
Outdated
| image: nebraltd/hm-diag:3e478a9 | ||
| image: nebraltd/hm-diag:625ea72 | ||
| depends_on: | ||
| - dbus-session | ||
| environment: | ||
| - FIRMWARE_VERSION=2021.11.26.1 | ||
| - DIAGNOSTICS_VERSION=3e478a9 |
There was a problem hiding this comment.
Should be updated to match the diag image.
docker-compose.yml
Outdated
| image: nebraltd/hm-diag:3e478a9 | ||
| image: nebraltd/hm-diag:625ea72 | ||
| depends_on: | ||
| - dbus-session | ||
| environment: | ||
| - FIRMWARE_VERSION=2021.11.26.1 |
There was a problem hiding this comment.
Should be 2021.11.22.0-2 or 2021.11.22.0-3. Same for the other FIRMWARE_VERSION.
There was a problem hiding this comment.
I guess 2021.11.26.1-1 could also work.
shawaj
reviewed
Nov 26, 2021
docker-compose.yml
Outdated
| volumes: | ||
| - pktfwdr:/var/pktfwd | ||
| - miner-storage:/var/data | ||
| - dbus:/session/dbus |
There was a problem hiding this comment.
Don't think we need to expose the session bus, just the system bus for what this is used for
There was a problem hiding this comment.
The only thing using the session bus is the miner FYI
|
There's also at the bottom another version number (for dbus container) |
shawaj
approved these changes
Nov 26, 2021
marvinmarnold
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Detect the BLE and LET devices in better way.
How
To get the BLE devices and LTE devices programatically using dbus, enable the dbus feature in
diagnosticscontainer.References
NebraLtd/hm-diag#96
NebraLtd/hm-diag#88
NebraLtd/hm-config#46
NebraLtd/hm-config#152
NebraLtd/hm-config#142
NebraLtd/hm-config#141